Skip to content

[Woo POS][Barcodes] Minor copy updates #15973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 5, 2025
Merged

[Woo POS][Barcodes] Minor copy updates #15973

merged 5 commits into from
Aug 5, 2025

Conversation

@staskus
Copy link
Contributor

@staskus staskus commented Aug 4, 2025

WOOMOB-926

Description

Make minor copy updates to barcode scanning implementation based on changes made on Android after testing:

  • Lowercase analytics scanner identifier for consistency between platforms
  • Make menu option naming more explicit
  • Update the success message for clarity

Steps to reproduce

  1. Open POS
  2. Select the menu
  3. Confirm "Initial barcode scanner setup" menu option
  4. Start setup flow
  5. Check tracking, confirm lowercase scanner identifier
  6. Complete the scanning flow
  7. Confirm the success message mentions that scanner will reconnect automatically next time

Testing information

iPad 26 device + Inateck scanner

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@staskus staskus added this to the 23.0 milestone Aug 4, 2025
@staskus staskus requested review from iamgabrielma and jaclync August 4, 2025 17:12
@staskus staskus added type: task An internally driven task. feature: POS labels Aug 4, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Aug 4, 2025

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Aug 4, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15973-e85b607
Version22.9
Bundle IDcom.automattic.alpha.woocommerce
Commite85b607
Installation URL4b4rqui2mefuo
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

jaclync
jaclync approved these changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Lowercase analytics scanner identifier for consistency between platforms

Looks like 3 test cases need some updates from this change.

@staskus
Copy link
Contributor Author

staskus commented Aug 5, 2025

Looks like 3 test cases need some updates from this change.

... forgot to push it yesterday 🤦

@staskus staskus enabled auto-merge August 5, 2025 07:30
@staskus staskus merged commit 56ca8c3 into trunk Aug 5, 2025
13 checks passed
@staskus staskus deleted the woomob-926-woo-posbarcodes-cft-updates branch August 5, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaclync jaclync jaclync approved these changes

@iamgabrielma iamgabrielma Awaiting requested review from iamgabrielma

Assignees

No one assigned

Labels

feature: POS type: task An internally driven task.

Projects

None yet

Milestone

23.0

Development

Successfully merging this pull request may close these issues.

5 participants

@staskus @dangermattic @wpmobilebot @jaclync